Skip to content

Minor comment error in node_tracers #46

Description

@gareth-robinson

In node_tracers.js for RawRESTkinHTTPTracer there is the comment "This implementation posts all traces immediately and does not implement buffering". Then there is RESTkinHTTPTracer, which uses the RawRESTkinHTTPTracer with the BufferingTracer and so doesn't have the comment above

For RawZipkinQueryServiceHTTPTracer there is similarly the comment "does not implement buffering of any sort". Then there is ZipkinQueryServiceHTTPTracer which uses the RawZipkinQueryServiceHTTPTracer with the BufferingTracer. However, the comment above ZipkinQueryServiceHTTPTracer also says "does not implement buffering of any sort" - so is this last comment a mistake?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions