Skip to content

fix envvars.update() ReferenceError outside task context (#4264) #4886

Description

@piyush15102003

Why do you want to contribute?

I'd like to fix #4264. The non-task-context branch of update() in the SDK's envvars.ts references name, but the parameter actually in scope is nameOrRequestOptions, so it throws ReferenceError whenever update() is called outside a task. I've got the repo running locally and I'd add a regression test covering the non-task-context path alongside the fix.

Prior contributions or relevant experience

First time contributing to trigger.dev, so requesting a vouch before opening a PR. I've recently opened PRs against Adyen's Java API library, Autodesk Forge, InterFax and Infor's ION SDK, backend engineer, 1.5 years, mostly Java/Spring in fintech, working in TypeScript/Node now.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions