forked from kcp-dev/api-syncagent
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathsyncer_related_test.go
More file actions
648 lines (579 loc) · 23.1 KB
/
Copy pathsyncer_related_test.go
File metadata and controls
648 lines (579 loc) · 23.1 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
/*
Copyright 2025 The KCP Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package sync
import (
"testing"
"go.uber.org/zap"
dummyv1alpha1 "github.com/kcp-dev/api-syncagent/internal/sync/apis/dummy/v1alpha1"
syncagentv1alpha1 "github.com/kcp-dev/api-syncagent/sdk/apis/syncagent/v1alpha1"
"github.com/kcp-dev/logicalcluster/v3"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
"k8s.io/apimachinery/pkg/labels"
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/apimachinery/pkg/util/sets"
ctrlruntimeclient "sigs.k8s.io/controller-runtime/pkg/client"
)
func TestEffectiveCleanupPolicy(t *testing.T) {
testcases := []struct {
name string
cleanup bool
policy syncagentv1alpha1.RelatedResourceCleanupPolicy
expected syncagentv1alpha1.RelatedResourceCleanupPolicy
}{
{
name: "no cleanup, no policy defaults to Orphan",
expected: syncagentv1alpha1.RelatedResourceCleanupPolicyOrphan,
},
{
name: "legacy cleanup:true maps to OnPrimaryDeletion",
cleanup: true,
expected: syncagentv1alpha1.RelatedResourceCleanupPolicyOnPrimaryDeletion,
},
{
name: "explicit Orphan wins over cleanup:false",
policy: syncagentv1alpha1.RelatedResourceCleanupPolicyOrphan,
expected: syncagentv1alpha1.RelatedResourceCleanupPolicyOrphan,
},
{
name: "explicit policy wins over legacy cleanup:true",
cleanup: true,
policy: syncagentv1alpha1.RelatedResourceCleanupPolicyMatchOrigin,
expected: syncagentv1alpha1.RelatedResourceCleanupPolicyMatchOrigin,
},
{
name: "explicit OnPrimaryDeletion without cleanup",
policy: syncagentv1alpha1.RelatedResourceCleanupPolicyOnPrimaryDeletion,
expected: syncagentv1alpha1.RelatedResourceCleanupPolicyOnPrimaryDeletion,
},
{
name: "explicit MatchOrigin without cleanup",
policy: syncagentv1alpha1.RelatedResourceCleanupPolicyMatchOrigin,
expected: syncagentv1alpha1.RelatedResourceCleanupPolicyMatchOrigin,
},
}
for _, tc := range testcases {
t.Run(tc.name, func(t *testing.T) {
spec := &syncagentv1alpha1.RelatedResourceSpec{
Cleanup: tc.cleanup,
CleanupPolicy: tc.policy,
}
if got := spec.EffectiveCleanupPolicy(); got != tc.expected {
t.Errorf("expected %q, got %q", tc.expected, got)
}
})
}
}
func TestRelatedCopyLabelsSelectorRoundTrip(t *testing.T) {
primary := &unstructured.Unstructured{}
primary.SetName("my-primary")
primary.SetNamespace("some-namespace")
const (
clusterName = logicalcluster.Name("cluster-a")
publishedRes = "published-resource-a"
identifier = "credentials"
agentName = "agent-1"
)
labelSet := relatedCopyLabels(primary, clusterName, publishedRes, identifier, agentName)
// the labels produced for a copy must match the selector used to find them again.
selector := relatedCopySelector(primary, clusterName, publishedRes, identifier, agentName)
if !selector.Matches(labels.Set(labelSet)) {
t.Errorf("selector %q does not match its own labels %v", selector, labelSet)
}
// a selector for a different identifier must not match.
otherIdentifier := relatedCopySelector(primary, clusterName, publishedRes, "other", agentName)
if otherIdentifier.Matches(labels.Set(labelSet)) {
t.Errorf("selector for a different identifier unexpectedly matched labels %v", labelSet)
}
// a selector for a different agent must not match.
otherAgent := relatedCopySelector(primary, clusterName, publishedRes, identifier, "agent-2")
if otherAgent.Matches(labels.Set(labelSet)) {
t.Errorf("selector for a different agent unexpectedly matched labels %v", labelSet)
}
// a selector for a different primary object must not match.
otherPrimary := &unstructured.Unstructured{}
otherPrimary.SetName("other-primary")
otherPrimary.SetNamespace("some-namespace")
if relatedCopySelector(otherPrimary, clusterName, publishedRes, identifier, agentName).Matches(labels.Set(labelSet)) {
t.Errorf("selector for a different primary unexpectedly matched labels %v", labelSet)
}
// a selector for a primary in a different logical cluster (workspace) must not match; the
// destination is shared across workspaces, so two primaries with identical name+namespace in
// different clusters must not prune each other's copies.
if relatedCopySelector(primary, "cluster-b", publishedRes, identifier, agentName).Matches(labels.Set(labelSet)) {
t.Errorf("selector for a different cluster unexpectedly matched labels %v", labelSet)
}
// a selector for a different owning PublishedResource must not match; two PublishedResources that
// project to the same Kind, reuse an identifier and have primaries sharing name+namespace must
// not prune each other's copies.
if relatedCopySelector(primary, clusterName, "published-resource-b", identifier, agentName).Matches(labels.Set(labelSet)) {
t.Errorf("selector for a different published resource unexpectedly matched labels %v", labelSet)
}
// a cluster-scoped primary (no namespace) still produces a valid, round-tripping label set; its
// empty namespace folds into the owner hash and cannot collide with a namespaced primary.
clusterPrimary := &unstructured.Unstructured{}
clusterPrimary.SetName("cluster-primary")
clusterLabels := relatedCopyLabels(clusterPrimary, clusterName, publishedRes, identifier, agentName)
if _, ok := clusterLabels[relatedOwnerLabel]; !ok {
t.Errorf("expected a related-owner label, got %v", clusterLabels)
}
if !relatedCopySelector(clusterPrimary, clusterName, publishedRes, identifier, agentName).Matches(labels.Set(clusterLabels)) {
t.Errorf("cluster-scoped selector does not match its own labels %v", clusterLabels)
}
// the provenance is exactly the three labels (owner + identifier + agent); the four separate
// cluster/PublishedResource/name/namespace labels were collapsed into the single owner hash.
if len(labelSet) != 3 {
t.Errorf("expected exactly 3 provenance labels (owner, identifier, agent), got %d: %v", len(labelSet), labelSet)
}
}
func TestRememberRelatedObjectsSkipsEmptyResolution(t *testing.T) {
const identifier = "credentials"
relatedAnnotation := relatedObjectAnnotationPrefix + identifier + ".0"
// A primary that already carries a related-object annotation for this identifier (from a previous
// pass) plus an unrelated annotation that must never be touched.
primary := newUnstructured(&corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: "my-primary",
Namespace: "default",
Annotations: map[string]string{
relatedAnnotation: `{"name":"secret-copy","namespace":"default","apiVersion":"v1","kind":"Secret"}`,
"example.com/keep": "yes",
},
},
})
client := buildFakeClient(primary)
remote := syncSide{object: primary.DeepCopy(), client: client}
s := &ResourceSyncer{}
// With an empty resolved set, the informational annotations must be left untouched: no patch, no
// requeue. Wiping them here would churn the primary object for every cleanup policy, not just the
// pruning ones (the prune below is the authoritative cleanup for the copies themselves).
requeue, err := s.rememberRelatedObjects(t.Context(), zap.NewNop().Sugar(), remote, identifier, nil)
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if requeue {
t.Error("expected requeue=false for an empty resolution, but got true")
}
persisted := &unstructured.Unstructured{}
persisted.SetGroupVersionKind(primary.GroupVersionKind())
if err := client.Get(t.Context(), ctrlruntimeclient.ObjectKeyFromObject(primary), persisted); err != nil {
t.Fatalf("failed to get persisted object: %v", err)
}
if got := persisted.GetAnnotations()[relatedAnnotation]; got == "" {
t.Error("expected the pre-existing related-object annotation to be preserved, but it was wiped")
}
if got := persisted.GetAnnotations()["example.com/keep"]; got != "yes" {
t.Errorf("unrelated annotation must be preserved, got %q", got)
}
}
func TestPruneRelatedCopies(t *testing.T) {
log := zap.NewNop().Sugar()
const (
clusterName = logicalcluster.Name("cluster-a")
publishedRes = "pr-a"
identifier = "credentials"
agentName = "agent-1"
)
primary := &unstructured.Unstructured{}
primary.SetAPIVersion("v1")
primary.SetKind("ConfigMap")
primary.SetName("my-primary")
primary.SetNamespace("default")
secretGVK := schema.GroupVersionKind{Version: "v1", Kind: "Secret"}
selector := relatedCopySelector(primary, clusterName, publishedRes, identifier, agentName)
// makeCopy builds a Secret carrying the provenance labels for the given identifier (so it is only
// in scope for that identifier's selector), optionally with a finalizer.
makeCopy := func(name, namespace, forIdentifier string, withFinalizer bool) *unstructured.Unstructured {
meta := metav1.ObjectMeta{
Name: name,
Namespace: namespace,
Labels: relatedCopyLabels(primary, clusterName, publishedRes, forIdentifier, agentName),
}
if withFinalizer {
meta.Finalizers = []string{"example.com/test"}
}
return newUnstructured(&corev1.Secret{ObjectMeta: meta})
}
// listSecretNames returns the names of all Secrets currently present, for assertions.
listSecretNames := func(t *testing.T, client ctrlruntimeclient.Client) sets.Set[string] {
t.Helper()
list := &corev1.SecretList{}
if err := client.List(t.Context(), list); err != nil {
t.Fatalf("failed to list secrets: %v", err)
}
names := sets.New[string]()
for _, item := range list.Items {
names.Insert(item.Name)
}
return names
}
// "foreign" is a copy for a different related resource identifier on the same primary; the
// credentials selector must never match it, so it is never pruned.
foreign := makeCopy("foreign-copy", "default", "other-identifier", false)
t.Run("mid-life prune deletes copies outside the keep set and leaves the rest", func(t *testing.T) {
keepMe := makeCopy("keep-me", "default", identifier, false)
pruneMe := makeCopy("prune-me", "other-ns", identifier, false) // also proves cross-namespace pruning
client := buildFakeClient(keepMe, pruneMe, foreign)
keep := sets.New(relatedCopyKey("default", "keep-me"))
requeue, err := (&ResourceSyncer{}).pruneRelatedCopies(t.Context(), log, syncSide{client: client}, primary, secretGVK, selector, keep, false)
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !requeue {
t.Error("expected requeue=true after deleting a copy")
}
remaining := listSecretNames(t, client)
if !remaining.Has("keep-me") {
t.Error("kept copy was unexpectedly deleted")
}
if remaining.Has("prune-me") {
t.Error("stale copy outside the keep set was not pruned")
}
if !remaining.Has("foreign-copy") {
t.Error("copy for a different identifier must not be pruned")
}
})
t.Run("teardown deletes every matching copy but not foreign copies", func(t *testing.T) {
a := makeCopy("copy-a", "default", identifier, false)
b := makeCopy("copy-b", "default", identifier, false)
client := buildFakeClient(a, b, foreign)
requeue, err := (&ResourceSyncer{}).pruneRelatedCopies(t.Context(), log, syncSide{client: client}, primary, secretGVK, selector, nil, true)
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !requeue {
t.Error("expected requeue=true after deleting copies")
}
remaining := listSecretNames(t, client)
if remaining.Has("copy-a") || remaining.Has("copy-b") {
t.Errorf("expected all matching copies to be deleted, still present: %v", remaining)
}
if !remaining.Has("foreign-copy") {
t.Error("copy for a different identifier must not be pruned")
}
})
t.Run("empty match set is a no-op", func(t *testing.T) {
client := buildFakeClient(foreign)
requeue, err := (&ResourceSyncer{}).pruneRelatedCopies(t.Context(), log, syncSide{client: client}, primary, secretGVK, selector, nil, true)
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if requeue {
t.Error("expected requeue=false when nothing matches the selector")
}
if !listSecretNames(t, client).Has("foreign-copy") {
t.Error("non-matching copy must be left untouched")
}
})
t.Run("copy already being deleted requeues instead of erroring", func(t *testing.T) {
deleting := makeCopy("deleting-copy", "default", identifier, true)
client := buildFakeClient(deleting)
// Delete it once: because it has a finalizer, the fake client only sets a deletion timestamp
// and retains the object, mimicking a copy that is mid-deletion.
if err := client.Delete(t.Context(), deleting); err != nil {
t.Fatalf("failed to start deletion: %v", err)
}
requeue, err := (&ResourceSyncer{}).pruneRelatedCopies(t.Context(), log, syncSide{client: client}, primary, secretGVK, selector, nil, true)
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !requeue {
t.Error("expected requeue=true so the reconcile comes back once the copy is gone")
}
if !listSecretNames(t, client).Has("deleting-copy") {
t.Error("a copy that is already being deleted must not be treated as an error or vanish early")
}
})
}
// TestConfirmOriginEmpty guards the safety check that prevents a MatchOrigin prune from deleting
// every related copy on a merely-transiently-empty resolution: the primary's cache-backed origin
// read can momentarily return nothing (relisting/stale informer) even though the origin objects
// still exist. confirmOriginEmpty re-runs the resolution against a live reader to distinguish a
// genuine empty origin (prune) from a stale one (skip + requeue).
func TestConfirmOriginEmpty(t *testing.T) {
// A related Secret found via a label selector in a fixed namespace.
relRes := syncagentv1alpha1.RelatedResourceSpec{
Identifier: "credentials",
Origin: syncagentv1alpha1.RelatedResourceOriginService,
Kind: "Secret",
Object: syncagentv1alpha1.RelatedResourceObject{
RelatedResourceObjectSpec: syncagentv1alpha1.RelatedResourceObjectSpec{
Selector: &syncagentv1alpha1.RelatedResourceObjectSelector{
LabelSelector: metav1.LabelSelector{
MatchLabels: map[string]string{"app": "credentials"},
},
Rewrite: syncagentv1alpha1.RelatedResourceSelectorRewrite{
Template: &syncagentv1alpha1.TemplateExpression{Template: "{{ .Value }}"},
},
},
},
// static namespace so resolution never depends on the primary's namespace.
Namespace: &syncagentv1alpha1.RelatedResourceObjectSpec{
Template: &syncagentv1alpha1.TemplateExpression{Template: "dummy-namespace"},
},
},
}
// origin: service, so origin = local (service cluster), dest = remote (kcp).
originPrimary := &unstructured.Unstructured{}
originPrimary.SetName("my-primary")
destPrimary := &unstructured.Unstructured{}
destPrimary.SetName("my-primary")
credSecret := newUnstructured(&corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Namespace: "dummy-namespace",
Name: "cred-1",
Labels: map[string]string{"app": "credentials"},
},
})
// The origin-side cached client is EMPTY: this simulates the reconcile seeing a stale/relisting
// cache that returns no objects even though the origin Secret still exists.
origin := syncSide{client: buildFakeClient(), object: originPrimary}
dest := syncSide{client: buildFakeClient(), object: destPrimary}
t.Run("no live reader configured is reported as not-checked", func(t *testing.T) {
s := &ResourceSyncer{}
empty, checked, err := s.confirmOriginEmpty(t.Context(), origin, dest, relRes)
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if checked {
t.Error("expected checked=false when no live reader is configured")
}
if empty {
t.Error("expected empty=false (unverified) when no live reader is configured")
}
})
t.Run("live read still sees origin objects: not confirmed empty", func(t *testing.T) {
// The live reader sees the Secret the stale cache missed, so the destructive prune must be
// held back.
s := &ResourceSyncer{localAPIReader: buildFakeClient(credSecret)}
empty, checked, err := s.confirmOriginEmpty(t.Context(), origin, dest, relRes)
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !checked {
t.Fatal("expected checked=true when a live reader is configured")
}
if empty {
t.Error("expected confirmedEmpty=false because the live read still sees the origin Secret")
}
})
t.Run("live read also empty: confirmed empty", func(t *testing.T) {
// Both the cache and the live read agree there is nothing, so the prune may proceed.
s := &ResourceSyncer{localAPIReader: buildFakeClient()}
empty, checked, err := s.confirmOriginEmpty(t.Context(), origin, dest, relRes)
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !checked {
t.Fatal("expected checked=true when a live reader is configured")
}
if !empty {
t.Error("expected confirmedEmpty=true because the live read also finds no origin objects")
}
})
}
func TestResolveRelatedResourceObjects(t *testing.T) {
// in kcp
primaryObject := newUnstructured(&dummyv1alpha1.Thing{
ObjectMeta: metav1.ObjectMeta{
Name: "my-test-thing",
},
Spec: dummyv1alpha1.ThingSpec{
Username: "original-value",
Kink: "taxreturns",
},
}, withKind("RemoteThing"))
// on the service cluster
primaryObjectCopy := newUnstructured(&dummyv1alpha1.Thing{
ObjectMeta: metav1.ObjectMeta{
Name: "my-test-thing",
},
Spec: dummyv1alpha1.ThingSpec{
Username: "mutated-value",
Kink: "",
},
})
// Create a secret that can be found by using a good reference, so we can ensure that references
// do indeed work; all other subtests here ensure that reference support can deal with broken refs.
dummySecret := newUnstructured(&corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Namespace: "dummy-namespace",
Name: "mutated-value",
},
})
kcpClient := buildFakeClient(primaryObject)
serviceClusterClient := buildFakeClient(primaryObjectCopy, dummySecret)
// Now we configure origin/dest as if we're syncing a Secret up from the service cluster to kcp,
// i.e. origin=service.
originSide := syncSide{
client: serviceClusterClient,
object: primaryObjectCopy,
}
destSide := syncSide{
client: kcpClient,
object: primaryObject,
// Since this is a just a regular kube client, we do not need to set clusterName/clusterPath.
}
testcases := []struct {
name string
objectSpec syncagentv1alpha1.RelatedResourceObject
expectedSecrets int
}{
{
name: "valid reference to an existing object",
objectSpec: syncagentv1alpha1.RelatedResourceObject{
RelatedResourceObjectSpec: syncagentv1alpha1.RelatedResourceObjectSpec{
Reference: &syncagentv1alpha1.RelatedResourceObjectReference{
Path: "spec.username",
},
},
Namespace: &syncagentv1alpha1.RelatedResourceObjectSpec{
Template: &syncagentv1alpha1.TemplateExpression{
Template: "dummy-namespace",
},
},
},
expectedSecrets: 1,
},
{
name: "valid template to an existing object",
objectSpec: syncagentv1alpha1.RelatedResourceObject{
RelatedResourceObjectSpec: syncagentv1alpha1.RelatedResourceObjectSpec{
Template: &syncagentv1alpha1.TemplateExpression{
Template: "{{ .Object.spec.username }}",
},
},
Namespace: &syncagentv1alpha1.RelatedResourceObjectSpec{
Template: &syncagentv1alpha1.TemplateExpression{
Template: "dummy-namespace",
},
},
},
expectedSecrets: 1,
},
{
name: "valid reference but target object doesn't exist [yet?]",
objectSpec: syncagentv1alpha1.RelatedResourceObject{
RelatedResourceObjectSpec: syncagentv1alpha1.RelatedResourceObjectSpec{
Reference: &syncagentv1alpha1.RelatedResourceObjectReference{
Path: "spec.username",
},
},
Namespace: &syncagentv1alpha1.RelatedResourceObjectSpec{
Template: &syncagentv1alpha1.TemplateExpression{
Template: "nonexisting-namespace",
},
},
},
expectedSecrets: 0,
},
{
name: "valid template but target object doesn't exist [yet?]",
objectSpec: syncagentv1alpha1.RelatedResourceObject{
RelatedResourceObjectSpec: syncagentv1alpha1.RelatedResourceObjectSpec{
Template: &syncagentv1alpha1.TemplateExpression{
Template: "{{ .Object.spec.username }}",
},
},
Namespace: &syncagentv1alpha1.RelatedResourceObjectSpec{
Template: &syncagentv1alpha1.TemplateExpression{
Template: "nonexisting-namespace",
},
},
},
expectedSecrets: 0,
},
{
name: "valid reference to an empty field",
objectSpec: syncagentv1alpha1.RelatedResourceObject{
RelatedResourceObjectSpec: syncagentv1alpha1.RelatedResourceObjectSpec{
Reference: &syncagentv1alpha1.RelatedResourceObjectReference{
Path: "spec.kink",
},
},
Namespace: &syncagentv1alpha1.RelatedResourceObjectSpec{
Template: &syncagentv1alpha1.TemplateExpression{
Template: "dummy-namespace",
},
},
},
expectedSecrets: 0,
},
{
name: "valid template to an empty field",
objectSpec: syncagentv1alpha1.RelatedResourceObject{
RelatedResourceObjectSpec: syncagentv1alpha1.RelatedResourceObjectSpec{
Template: &syncagentv1alpha1.TemplateExpression{
Template: "{{ .Object.spec.kink }}",
},
},
Namespace: &syncagentv1alpha1.RelatedResourceObjectSpec{
Template: &syncagentv1alpha1.TemplateExpression{
Template: "dummy-namespace",
},
},
},
expectedSecrets: 0,
},
{
name: "referring to an omitempty field",
objectSpec: syncagentv1alpha1.RelatedResourceObject{
RelatedResourceObjectSpec: syncagentv1alpha1.RelatedResourceObjectSpec{
Reference: &syncagentv1alpha1.RelatedResourceObjectReference{
Path: "spec.address",
},
},
Namespace: &syncagentv1alpha1.RelatedResourceObjectSpec{
Template: &syncagentv1alpha1.TemplateExpression{
Template: "dummy-namespace",
},
},
},
expectedSecrets: 0,
},
{
name: "templating an omitempty field",
objectSpec: syncagentv1alpha1.RelatedResourceObject{
RelatedResourceObjectSpec: syncagentv1alpha1.RelatedResourceObjectSpec{
Template: &syncagentv1alpha1.TemplateExpression{
Template: "{{ .Object.spec.address }}",
},
},
Namespace: &syncagentv1alpha1.RelatedResourceObjectSpec{
Template: &syncagentv1alpha1.TemplateExpression{
Template: "dummy-namespace",
},
},
},
expectedSecrets: 0,
},
}
for _, testcase := range testcases {
t.Run(testcase.name, func(t *testing.T) {
pubRes := syncagentv1alpha1.RelatedResourceSpec{
Identifier: "test",
Origin: syncagentv1alpha1.RelatedResourceOriginService,
Kind: "Secret",
Object: testcase.objectSpec,
}
foundObjects, err := resolveRelatedResourceObjects(t.Context(), zap.NewNop().Sugar(), originSide, destSide, pubRes)
if err != nil {
t.Fatalf("Failed to resolve related objects: %v", err)
}
if len(foundObjects) != testcase.expectedSecrets {
t.Fatalf("Expected %d related object (Secret) to be found, but found %d.", testcase.expectedSecrets, len(foundObjects))
}
})
}
}