Deprecated conditions possibly incoherent

[perdasilva]

The *Deprecated conditions report a status of False with reason Deprecated. Should it not be, Not deprecated?

{
    "lastTransitionTime": "2025-06-03T07:52:54Z",
    "message": "",
    "observedGeneration": 1,
    "reason": "Deprecated",
    "status": "False",
    "type": "Deprecated"
},
{
    "lastTransitionTime": "2025-06-03T07:52:54Z",
    "message": "",
    "observedGeneration": 1,
    "reason": "Deprecated",
    "status": "False",
    "type": "PackageDeprecated"
},
{
    "lastTransitionTime": "2025-06-03T07:52:54Z",
    "message": "",
    "observedGeneration": 1,
    "reason": "Deprecated",
    "status": "False",
    "type": "ChannelDeprecated"
},
{
    "lastTransitionTime": "2025-06-03T07:52:54Z",
    "message": "",
    "observedGeneration": 1,
    "reason": "Deprecated",
    "status": "False",
    "type": "BundleDeprecated"
}

[joelanford]

+1. Reason should be NotDeprecated when status is "False"

[joelanford]

Alternatively, perhaps the condition should just not be present when the status would otherwise be "False"

[camilamacedo86]

IHMO to follow k8s style we should here add a new extra condition:

const (
    ReasonDeprecated    = "Deprecated"
    ReasonNotDeprecated = "NotDeprecated"
    ReasonAbsent        = "Absent"
)

But for that work well we need first fix the leak: #2296
Then we can address this one with: a0dc469 ( follow up )

[grokspawn]

Just pointing out that this was litigated once: https://docs.google.com/document/d/1CYGANKILfzfOoWtHvyg4luF7i-cC1NRa7_1N9xTLatw/

[github-actions]

Issues go stale after 90 days of inactivity. If there is no further activity, the issue will be closed in another 30 days.

[github-actions]

This issue has been closed due to inactivity.