Skip to content

Feature Request: Lombok Style Builders #554

Description

@morrica

Lombok's builder pattern uses a static method, builder(), to obtain builders for annotated objects. Many tools, like MapStruct, are designed to automatically detect builders of this pattern. The MinFraud SDK uses constructors to create builders (new Type.Builder()) and some of those constructors take arguments (Transaction.Builder(device)). This makes it combersome integrate the MinFraud SDK with tools expecting Lombok pattern builders.

Please consider modifying the current builder pattern to match Lombok or add Lombok pattern builders in addition to your current pattern in a future release.

The change would be:

Transaction.builder()
    .device(device)
    .build();

Rather than:

new Transaction.Builder(device)
    .build();

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions