Skip to content

required should be inferred from the return type of a hybrid property #427

Description

@snstanton

With a definition like:

@hybrid_property
def is_active(self) -> bool:
    return self.state == 'ACTIVE'

The resulting graphql field type is currently marked Boolean unless overridden by ORMField(). Column properties correctly determine the nullability from the column definition. It seems reasonable to do the same for the hybrid_property based on the declared type. If the return type were bool | None, then it would be optional, otherwise it should be required.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions