Skip to content

Commit a13b293

Browse files
committed
ci: move gdb to control build-deps so package-arch tests get it too
gdb was only added to .github/scripts/install-deps.sh, which runs on the Ubuntu rip-and-test jobs. The package-arch jobs build and test in debian containers and install build deps via apt-get build-dep, so they never got gdb and the ui-smoke crash dump path had none when a GUI cored there (hdiethelm, PR LinuxCNC#4136 review). Move gdb to debian/control.top.in under <!nocheck>, next to the other test-only deps (xvfb, x11-utils, imagemagick). build-dep installs it for both the rip jobs and the package-arch jobs, so the explicit entry in install-deps.sh is now redundant and dropped.
1 parent fe5b432 commit a13b293

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

‎.github/scripts/install-deps.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ set -eu #Needed so CI fails when anything is wrong
44
set -x
55

66
sudo apt-get --quiet update
7-
sudo apt-get install --yes --no-install-recommends devscripts equivs build-essential lintian clang gdb
7+
sudo apt-get install --yes --no-install-recommends devscripts equivs build-essential lintian clang
88
debian/configure
99
sudo apt-get --yes build-dep .

‎debian/control.top.in‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ Build-Depends:
4949
xvfb <!nocheck>,
5050
x11-xserver-utils <!nocheck>,
5151
x11-utils <!nocheck>,
52+
gdb <!nocheck>,
5253
imagemagick <!nocheck>,
5354
python3-opengl <!nocheck>,
5455
python3-pyqt5 <!nocheck>,

0 commit comments

Comments
 (0)