Skip to content

Pager options not honored with click>=8.1.8 #240

Description

@the-noob-of-northrose

Seemingly related to #225

I just installed litecli today using pip, and click was 8.3.0 per the dependency specification excluding 8.1.*

My $PAGER variable is set to less -iJS (case-insensitive search, show status column, don't wrap long lines) but I noticed that the output in litecli was not honoring this (there should be an empty first column, long lines are still wrapped, searching for "afghanistan" finds no results).

Image

When I manually downgrade click to 8.1.7 or lower, this works as expected:

Image

(Status column shown [-J], lines are not wrapped [-S], searching for "afghanistan" still finds "AFGHANISTAN" [-i])

8.1.8 is the first "bad" version and this issue has not been fixed in click 8.2.* or 8.3.0.

Can you please update the dependency specifications to use 8.1.7 or lower?
I am not 100% sure but perhaps click>=4.1,<=8.1.7 would be appropriate.

Thank you!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    symphony:reviewSymphony output is ready for human review

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions