From 23b66da60b42fba7a21cc47519773a7ba62c4b1c Mon Sep 17 00:00:00 2001 From: Russell Spitzer Date: Wed, 9 Sep 2026 17:13:03 -0500 Subject: [PATCH] Prepare RC: install Thrift before the release build MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit parquet-format-structures compiles .thrift sources with the thrift binary, but release-prepare-rc.yml never installed it, so the release build failed with "thrift: not found" once it reached module 2. This was masked until now because earlier runs failed on the Nexus deploy of module 1 and never got that far. Reuse dev/ci-before_install.sh — the same script ci-hadoop3.yml uses — so the release build compiles against the Thrift version CI validated against, and a future version bump updates both together. CI_TARGET_BRANCH is deliberately left unset. It makes the script source dev/ci-before_install-.sh, and the only such script is a master-branch SNAPSHOT check that is irrelevant to a release build. release-publish.yml needs no equivalent change: its only Maven call is ./mvnw -pl . versions:set-property, which compiles nothing. Co-Authored-By: Claude Opus 5 (1M context) --- .github/workflows/release-prepare-rc.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/release-prepare-rc.yml b/.github/workflows/release-prepare-rc.yml index 37f90126ce..a0c81036a2 100644 --- a/.github/workflows/release-prepare-rc.yml +++ b/.github/workflows/release-prepare-rc.yml @@ -76,6 +76,10 @@ jobs: - name: Install Subversion run: sudo apt-get update -q && sudo apt-get install -q -y subversion + - name: Install Thrift + # parquet-format-structures needs the thrift compiler. + run: bash dev/ci-before_install.sh + - name: Prepare Release Candidate env: DRY_RUN: ${{ inputs.dry_run && '1' || '0' }}