From 706e6d5d5a4a97fcf46a43a65f6bc3c84acb74d6 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 3 Sep 2026 12:20:21 +0200 Subject: [PATCH 1/3] Update code review guidelines in SKILL.md Clarify criteria for code review and coding style. --- .github/skills/code-review/SKILL.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/skills/code-review/SKILL.md b/.github/skills/code-review/SKILL.md index 9ed32098a796..5f1bfb5d37a9 100644 --- a/.github/skills/code-review/SKILL.md +++ b/.github/skills/code-review/SKILL.md @@ -2,7 +2,7 @@ Review a pull request against the rules already written in [`CONTRIBUTING.md`](../../../CONTRIBUTING.md). The goal is a review that any -reviewer (human or AI) can run the same way every time and that produces a clear, +reviewer (human or AI) can run the same way every time, and that produces a clear, kind, actionable verdict. ## How to run this skill @@ -16,14 +16,16 @@ suggest the fix — never just "rejected". - [ ] The change adds, fixes, or documents **one algorithm** — not multiple, and not both code and doctest changes in the same PR. - [ ] It is a genuine algorithm or data structure (see the *What is an Algorithm?* - section), not a script, snippet, or exercise dump. + section), not a script, snippet, how-to-use for an existing API, or exercise dump. - [ ] It is **not already in the repository** (search the existing directories). - [ ] **No earlier open PR** already does the same thing — link it if one exists. - [ ] Properly attributed — no plagiarism; prior sources credited. ### 2. Coding Style -- [ ] File and directory names are lowercase, use underscores, and land inside an +- [ ] `from __future__ import annotations` is not needed because this repo only uses on + the latest version of CPython. +- [ ] - [ ] File and directory names are lowercase, use underscores, and land inside an existing directory. - [ ] Public functions/classes have **type hints**. - [ ] Public functions have **doctests that actually pass**. From d3eaab2a88b063856f69c60c797608a3bbec054c Mon Sep 17 00:00:00 2001 From: cclauss Date: Thu, 3 Sep 2026 10:20:41 +0000 Subject: [PATCH 2/3] updating DIRECTORY.md --- DIRECTORY.md | 1 + 1 file changed, 1 insertion(+) diff --git a/DIRECTORY.md b/DIRECTORY.md index 5bb206e08c0e..c69605273647 100644 --- a/DIRECTORY.md +++ b/DIRECTORY.md @@ -462,6 +462,7 @@ ## Fuzzy Logic * [Fuzzy Operations](fuzzy_logic/fuzzy_operations.py) + * [Fuzzy Set Operations](fuzzy_logic/fuzzy_set_operations.py) ## Genetic Algorithm * [Basic String](genetic_algorithm/basic_string.py) From 6cfbbaafdc02577d20ad0a461b7fba640d87a37e Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 3 Sep 2026 12:22:45 +0200 Subject: [PATCH 3/3] Fix formatting issues in SKILL.md --- .github/skills/code-review/SKILL.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/skills/code-review/SKILL.md b/.github/skills/code-review/SKILL.md index 5f1bfb5d37a9..170b3f598576 100644 --- a/.github/skills/code-review/SKILL.md +++ b/.github/skills/code-review/SKILL.md @@ -16,16 +16,17 @@ suggest the fix — never just "rejected". - [ ] The change adds, fixes, or documents **one algorithm** — not multiple, and not both code and doctest changes in the same PR. - [ ] It is a genuine algorithm or data structure (see the *What is an Algorithm?* - section), not a script, snippet, how-to-use for an existing API, or exercise dump. + section), not a script, snippet, how-to-use for an existing API, or exercise + dump. - [ ] It is **not already in the repository** (search the existing directories). - [ ] **No earlier open PR** already does the same thing — link it if one exists. - [ ] Properly attributed — no plagiarism; prior sources credited. ### 2. Coding Style -- [ ] `from __future__ import annotations` is not needed because this repo only uses on +- [ ] `from __future__ import annotations` is not needed because this repo only uses the latest version of CPython. -- [ ] - [ ] File and directory names are lowercase, use underscores, and land inside an +- [ ] File and directory names are lowercase, use underscores, and land inside an existing directory. - [ ] Public functions/classes have **type hints**. - [ ] Public functions have **doctests that actually pass**.