bushes buildable over water

[733737]

trees have a flag that prevents them from being built on top of water. This flag should be applied to all bushes except the lilypad, including tropical bushes. I don't know if this flag is stored in the json or if it hardcoded to trees. If this is hardcoded, maybe we could change the flag so it could be implemented on a per object basis including for other objects besides trees or bushes; such as the time twister rock n roll vehicle objects.

[Gymnasiast]

It’s just a flag on the object. Changing it is easy, the more important bit is whether this is a good idea.

Deferring this to @ZeeMaji : do you think we should change this?

[ZeeMaji]

It's a kind of annoying thing, it also affects some trees like the dead trees from the spooky theming. So i think it could be a good idea.

[ZeeMaji]

This seems to be controlled by the "isStackable" flag, which seems like a bit of a problem as if you change this, you'll no longer be able to stack them which would limit their building potential.

[733737]

we should change the flag so that it has two variants isStackable and isStackableOnWater

[Gymnasiast]

Being able to build stuff in the air and on water is one and the same. So I need a decision whether to remove isStackable.

[733737]

most professionals disable clearance checks, so it should only effect regular users. I've seen people make different kinds of trees using bushes, but I don't know how many of them use disable clearance checks.

[kyphii]

I strongly disagree with this proposal. This property of bushes is used frequently in hackless builds to soften the edges of water features and add realistic foliage along the edges. It seems very silly to take this away.

As seen here

To make things even worse, the current implementation of the restriction also prevents trees from being placed on half-water tiles like this, even quarter-tile-trees, so all these spaces would also become off-limits.

please don't make me go through every single OpenScenarios map and remove all the bushes that would take a really long time and make it look worse thanks

[spacek531]

I think bushes should be left as-is

[ZeeMaji]

Yeah this definitely shouldn't be changed then in that case.

[Gymnasiast]

I would argue that means our clearance checks are broken and not necessarily that we need the bushes to be stackable.

[ZeeMaji]

For what it's worth. This flag is also used by some things that are definitely intended to be built over water, like the tall water fountains.

[Gymnasiast]

@kyphii Can you create issue(s) for the placement? It seems to me that at least part of the behaviour you describe is undesirable to begin with, regardless of flags.